Skip to content

[v0.19.1]: Temporarily work around deploy build command issue#2292

Merged
Adamantios merged 4 commits intovalory-xyz:mainfrom
8ball030:patch-3
Feb 4, 2025
Merged

[v0.19.1]: Temporarily work around deploy build command issue#2292
Adamantios merged 4 commits intovalory-xyz:mainfrom
8ball030:patch-3

Conversation

@8ball030
Copy link
Contributor

@8ball030 8ball030 commented Jan 13, 2025

Proposed changes

Resolves issue with path directory when using default build commands.

Adamantios
Adamantios reviewed Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@Adamantios Adamantios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please share more information on how to reproduce this issue?

It worries me a bit that the parent path did not exist. I would like to ensure that the solution does not cover a bug.

@8ball030
Copy link
Contributor Author

8ball030 commented Jan 27, 2025 •
edited
Loading

In order to reproduce;

A) create a new service (Note, this is to show the bug and can be done in any other repo with a service);

[I] eight@gefion ~/P/S/r/experimentation_station (main)> adev create author/cool_agent
16:52:31 INFO     Creating agent author/cool_agent:latest from template eightballer/frontend_agent                                                                                                   
16:52:40 INFO     Agent published successfully.                                                                                                                                                      
         INFO     Agent cleaned up successfully.                                                                                                                                                     
         INFO     Agent author/cool_agent:latest created successfully 🎉🎉🎉🎉                                                                                                                       
[I] eight@gefion ~/P/S/r/experimentation_station (main)> adev convert agent-to-service author/cool_agent author/cool_agent --force
16:52:48 INFO     Converting agent author/cool_agent:latest to service author/cool_agent:latest.                                                                                                     
         INFO     Conversion complete. Service is ready! 🚀

B) try to deploy that service;

autonomy generate-key ethereum -n 1
autonomy fetch --service --local author/cool_agent
cd cool_agent
autonomy deploy build ../keys.json --n 1

image

@Adamantios Adamantios removed the stale label Jan 28, 2025
@8ball030 8ball030 mentioned this pull request Jan 28, 2025
Closed
@Adamantios
Copy link
Collaborator

Adamantios commented Feb 3, 2025

An update regarding your PR:

  • It seems that there is indeed a bug, which was introduced in v0.18.4.
  • The bug went unnoticed because the Ubuntu unit test job has been timing out while still ❔showing a green status❔.
  • The solution suggested in this PR does not resolve the real source of the issue and will not be necessary after addressing it.

Please bear with us while we investigate the above situation.

@Adamantios Adamantios added the bug Something isn't working label Feb 3, 2025
@8ball030
Copy link
Contributor Author

8ball030 commented Feb 3, 2025 •
edited
Loading

coolio any idea when this will be resolved, is blocking us haha

That timing out out issue seems quite nasty to be honest.

You can specifically see its a cancelled job as well.

@Adamantios Adamantios changed the title Update base.py Temporarily work around deploy build command issue Feb 4, 2025
@Adamantios
Copy link
Collaborator

Adamantios commented Feb 4, 2025

coolio any idea when this will be resolved, is blocking us haha

Releasing this to unblock you. Will address the issues in #2292 (comment) in the next release.

@Adamantios Adamantios changed the title Temporarily work around deploy build command issue [v0.19.1]: Temporarily work around deploy build command issue Feb 4, 2025
@Adamantios Adamantios merged commit 5fb2c83 into valory-xyz:main Feb 4, 2025
23 checks passed
@8ball030
Copy link
Contributor Author

8ball030 commented Feb 4, 2025

Thank you alot ser

@Adamantios Adamantios mentioned this pull request Feb 12, 2025
Merged
13 tasks
Adamantios added a commit that referenced this pull request Feb 12, 2025
@Adamantios
fix: build the directories before generating the deployment
c8ba748 
The deployment build process requires the directories.

This commit properly fixes the issue that was worked around in #2292 and rolled back in 5e41dd7b0582933c16ec2a68ffbc35100e34d0d4.
@Adamantios Adamantios mentioned this pull request Feb 12, 2025
Merged
13 tasks
Adamantios added a commit that referenced this pull request Feb 12, 2025
@Adamantios
fix: build the directories before generating the deployment
31ffc2b 
The deployment build process requires the directories.

This commit properly fixes the issue that was worked around in #2292 and rolled back in e214049.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Adamantios Adamantios Adamantios approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@8ball030 @Adamantios